e2m/uWebSockets.js
3
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Stricter callback checks for app.get

Browse source
This commit is contained in:
Alex Hultman 2020-11-09 14:28:27 +01:00
parent efc5a4ee72
commit a2da9d8dd8
2 changed files with 33 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/AppWrapper.h
View file

@ -242,14 +242,21 @@ template <typename APP, typename F>
void uWS_App_get(F f, const FunctionCallbackInfo<Value> &args) {
APP *app = (APP *) args.Holder()->GetAlignedPointerFromInternalField(0);
/* Pattern */
NativeString pattern(args.GetIsolate(), args[0]);
if (pattern.isInvalid(args)) {
return;
}
/* Handler */
Callback checkedCallback(args[1]);
if (checkedCallback.isInvalid()) {
return;
}
UniquePersistent<Function> cb = checkedCallback.getFunction();
/* This function requires perContextData */
PerContextData *perContextData = (PerContextData *) Local<External>::Cast(args.Data())->Value();
UniquePersistent<Function> cb(args.GetIsolate(), Local<Function>::Cast(args[1]));
(app->*f)(std::string(pattern.getString()), [cb = std::move(cb), perContextData](auto *res, auto *req) {
Isolate *isolate = perContextData->isolate;