From d24d33d94cd7a5957ca09544c54d81bdf8fff0e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ken-H=C3=A5vard=20Lieng?= Date: Tue, 27 Nov 2018 11:34:02 +0100 Subject: [PATCH] Fix push cookie hash check --- server/serve_files.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/server/serve_files.go b/server/serve_files.go index 61289672..b44e8bc7 100644 --- a/server/serve_files.go +++ b/server/serve_files.go @@ -262,9 +262,11 @@ func (d *Dispatch) serveIndex(w http.ResponseWriter, r *http.Request) { } else { pushed := false - for i, asset := range h2PushAssets { - if len(cookie.Value) >= (i+1)*8 && - asset.hash != cookie.Value[i*8:(i+1)*8] { + i := 0 + for _, asset := range h2PushAssets { + if len(cookie.Value) >= i+len(asset.hash) && + asset.hash != cookie.Value[i:i+len(asset.hash)] { + i += len(asset.hash) pusher.Push(asset.path, options) pushed = true }